Re: [PATCH] MIPS: Include asm/ptrace.h now linux/sched.h doesn't

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* James Hogan <james.hogan@xxxxxxxxxx> wrote:

> Use of the task_pt_regs() based macros in MIPS' asm/processor.h for
> accessing the user context on the kernel stack need the definition of
> struct pt_regs from asm/ptrace.h. __own_fpu() in asm/fpu.h uses these
> macros but implicitly depended on linux/sched.h to include asm/ptrace.h.
> 
> Since commit f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from
> <linux/sched.h>") however linux/sched.h no longer includes asm/ptrace.h,
> so include it explicitly from asm/fpu.h where it is needed instead.
> 
> This fixes build errors such as:
> 
> ./arch/mips/include/asm/fpu.h: In function '__own_fpu':
> ./arch/mips/include/asm/processor.h:385:31: error: invalid application of 'sizeof' to incomplete type 'struct pt_regs'
>      THREAD_SIZE - 32 - sizeof(struct pt_regs))
>                                ^
> 
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from <linux/sched.h>")
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx

My build tests missed this bug, thanks James!

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

	Ingo




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux