Hi Thomas > No, please avoid "of_machine_is_compatible" in drivers. OK > We should introduce specific compatible strings for this driver, which trigger this, > e.g. "lantiq,nor-vr9" or "lantiq,nor-ar10" (or better using family names "xrx200" and "xrx300") You mean we can use the same way as other drivers, for example in the physmap_of_versatile.c file : static const struct of_device_id syscon_match[] = { { .compatible = "arm,integrator-ap-syscon", .data = (void *)INTEGRATOR_AP_FLASHPROT, }, { .compatible = "arm,integrator-cp-syscon", .data = (void *)INTEGRATOR_CP_FLASHPROT, }, etc... We can't filter on xrx200 or vr9, but we have to know the VR9 version (as the VR9 < 1.2 is not compatible with this patch). Regards, Sebastien