Re: [PATCH 1/5] MIPS: FW: Make fw_init_cmdline() to be __weak.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 22, 2016 at 01:43:54PM -0600, Steven J. Hill wrote:

> Some bootloaders pass the kernel parameters in different registers.
> Allow for platform-specific initialization of the command line.
> 
> Signed-off-by: Steven J. Hill <Steven.Hill@xxxxxxxxxx>
> ---
>  arch/mips/include/asm/fw/fw.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/fw/fw.h b/arch/mips/include/asm/fw/fw.h
> index d0ef8b4..0fcd63e 100644
> --- a/arch/mips/include/asm/fw/fw.h
> +++ b/arch/mips/include/asm/fw/fw.h
> @@ -21,7 +21,7 @@
>  #define fw_argv(index)		((char *)(long)_fw_argv[(index)])
>  #define fw_envp(index)		((char *)(long)_fw_envp[(index)])
> 
> -extern void fw_init_cmdline(void);
> +extern void __weak fw_init_cmdline(void);
>  extern char *fw_getcmdline(void);
>  extern void fw_meminit(void);
>  extern char *fw_getenv(char *name);

Nice try - expect it doesn't work.

The definition of the function needs to be marked __weak; marking the
declaration will only kindly express your wishes to GCC and it being
GCC will ignore them ;-)

  Ralf




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux