On Thu, Nov 10, 2016 at 09:17:31PM +0100, Wolfram Sang wrote:
> On Tue, Nov 08, 2016 at 08:13:37AM +0100, Jan Glauber wrote:
> > On Mon, Nov 07, 2016 at 08:09:20PM +0000, Paul Burton wrote:
> > > Commit 70121f7f3725 ("i2c: octeon: thunderx: Limit register access
> > > retries") attempted to replace potentially infinite loops with ones
> > > which will time out using readq_poll_timeout, but in doing so it
> > > inverted the condition for exiting this loop.
> > >
> > > Tested on a Rhino Labs UTM-8 with Octeon CN7130.
> > >
> > > Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
> > > Cc: Jan Glauber <jglauber@xxxxxxxxxx>
> > > Cc: David Daney <david.daney@xxxxxxxxxx>
> > > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> > > Cc: linux-i2c@xxxxxxxxxxxxxxx
> > >
> > > ---
> >
> > Acked-by: Jan Glauber <jglauber@xxxxxxxxxx>
> >
> > Thanks for spotting this. I think this should go into stable too for
> > 4.8, so adding Cc: stable@xxxxxxxxxxxxxxx.
>
> Shall I still apply this one? Seems to me that 70121f7f3725 is still
> under discussion of being reverted?
>
70121f7 needs to be reverted, but it looks like i2c devices are still
not working on Octeon after that. We are still debugging the issue,
so I would suggest to wait for some more days.
--Jan
