Re: [PATCH] MIPS: fix build with multiple PLATFORM strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, 25 October 2016 16:12:05 BST Manuel Lauss wrote:
> Commit cf2a5e0bb (MIPS: Support generating Flattened Image Trees (.itb))
> broke my alchemy devboard build, because it uses more than one entry
> in the PLATFORM variable:
> 
> make -f kernel/linux/scripts/Makefile.build obj=arch/mips/boot/compressed \
>         VMLINUX_LOAD_ADDRESS=[..] PLATFORM=alchemy/common/
> alchemy/devboards/ [..] vmlinuz make[2]: *** No rule to make target
> 'alchemy/devboards/'.  Stop.
> make[1]: *** [arch/mips/Makefile:371: vmlinuz] Error 2
> 
> Fix this by wrapping the platform-y expansion in quotes.

Hi Manuel,

This same fix was already submitted 8 days ago:

https://patchwork.linux-mips.org/patch/14405/

Thanks,
    Paul

> 
> Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxx>
> ---
>  arch/mips/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index fbf40d3..1a6bac7 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -263,7 +263,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if
> $(dataoffset-y),$(dataoffset-y),0)
> 
>  bootvars-y	= VMLINUX_LOAD_ADDRESS=$(load-y) \
>  		  VMLINUX_ENTRY_ADDRESS=$(entry-y) \
> -		  PLATFORM=$(platform-y)
> +		  PLATFORM="$(platform-y)"
>  ifdef CONFIG_32BIT
>  bootvars-y	+= ADDR_BITS=32
>  endif

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux