On Fri, 7 Oct 2016, James Hogan wrote: > > Also I've noticed $(aflags-vdso) duplicate `-I' and `-E' options already > > included with $(ccflags-vdso); I wonder if the duplicates should simply be > > removed or whether $(cflags-vdso) ought to filter from $(KBUILD_CFLAGS) > > and $(aflags-vdso) -- from $(KBUILD_AFLAGS) instead (or $(ccflags-vdso) > > should just take the options from $(KBUILD_CPPFLAGS)). Also why `-E' is > > supposed to take an argument? Can you please have a look at it? > > I think -E is to catch -EL / -EB. Ahh, forgot about the existence of these! > Removing the duplication is easily > fixed (I'll post a patch soon). As for whether it should filter from the > other KBUILD_ flags, I'm inclined to avoid changing it unless we can be > sure it will be more robust as a result. I've only been trying to figure out what Alex might have intended here. Obviously given that otherwise the current setup seems to work I tend to agree with you in that a simple removal of the duplication is the safest path of the least resistance fix. Maciej
