On 09/22/2016 03:13 PM, James Hogan wrote:
well it'll do a protected dcache flush (i.e. using CACHEE with EVA). Would kmap/kunmap or variants (fixed to work with aliasing dcache) be able to take care of colouring / further flushing?
We should flush kernel D-cache and user I-cache in any cache aliasing system. I was wrong - a fixed HIGHMEM doesn't do any difference actually, because page may be located in directly addressed memory (all HIGHMEM stuff is irrelevant in this case, kmap returns a lowmem address).
In any case, simply changing to the user_ one is a no-op compared to leaving as is where patch 9 would probably break it on EVA by making it operate only on kernel addresses.
EVA or not has no difference here - kernel address can still be a different color to user address.
And keeping kernel I-cache flush does break it really, not EVA. - Leonid.