Hi Aaro, On Tue, 13 Sep 2016 00:03:14 +0300, Aaro Koskinen <aaro.koskinen@xxxxxx> wrote: > On Mon, Sep 12, 2016 at 08:33:43PM +0000, Asbjoern Sloth Toennesen wrote: > > The patch will be followed by a similar patch to > > drivers/staging/octeon/ethernet.c > > I think you should: > > 1. Move this function to staging/octeon > > 2. Do required cleanups there > > 3. Finally delete the function under arch/mips > > We shouldn't start making cleanups (except code removal) to ethernet code > under mips/cavium-octeon/executive as it really does not belong there... I agree that this would make sense, however I just came across this looking at the general MTU code across drivers, and don't have a real interest in this particular driver nor mips, so I am not looking to fall that deep into the rabbit hole. -- Best regards Asbjørn Sloth Tønnesen
