On 09/01/2016 01:43 PM, Aaro Koskinen wrote:
PHY access through the board helper should be impossible with the current drivers, so delete this code and add BUG_ON(). Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx> --- .../cavium-octeon/executive/cvmx-helper-board.c | 110 +-------------------- 1 file changed, 5 insertions(+), 105 deletions(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c index 5572e39..8d75242 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
[...]
+ BUG_ON(cvmx_helper_board_get_mii_address(ipd_port) != -1);
Can we do WARN_ON instead? No need to crash the kernel for this I think. David Daney
