Re: [PATCH] MIPS: OCTEON: fix platform bus probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 23, 2016 at 1:39 PM, Aaro Koskinen <aaro.koskinen@xxxxxx> wrote:
> Commit 44a7185c2ae6 ("of/platform: Add common method to populate
> default bus") added new arch_initcall of_platform_default_populate_init()
> that will override device_initcall octeon_publish_devices(). This broke
> many OCTEON boards as important devices are not getting probed anymore
> (e.g. on EdgeRouter Lite the USB mass storage/rootfs is missing).

They are getting probed, but the order probably changed causing probe to fail.

> Fix by changing octeon_publish_devices() to arch_initcall.
>
> Fixes: 44a7185c2ae6 ("of/platform: Add common method to populate default bus")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> ---
>  arch/mips/cavium-octeon/octeon-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
> index b31fbc9..37a932d 100644
> --- a/arch/mips/cavium-octeon/octeon-platform.c
> +++ b/arch/mips/cavium-octeon/octeon-platform.c
> @@ -1059,7 +1059,7 @@ static int __init octeon_publish_devices(void)
>  {
>         return of_platform_bus_probe(NULL, octeon_ids, NULL);
>  }
> -device_initcall(octeon_publish_devices);
> +arch_initcall(octeon_publish_devices);
>
>  MODULE_AUTHOR("David Daney <ddaney@xxxxxxxxxxxxxxxxxx>");
>  MODULE_LICENSE("GPL");
> --
> 2.9.2
>




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux