On 08/16, Kelvin Cheung wrote: > Hi Stephen, > > 2016-08-16 7:28 GMT+08:00 Stephen Boyd <sboyd@xxxxxxxxxxxxxx>: > > > On 08/12, Keguang Zhang wrote: > > > From: Kelvin Cheung <keguang.zhang@xxxxxxxxx> > > > > > > This patch changes the OSC clock name to "osc_clk". > > > > > > Signed-off-by: Kelvin Cheung <keguang.zhang@xxxxxxxxx> > > > --- > > > > Yes, but why? > > > > > Loongson1C uses a 24MHz oscillator, hence "osc_clk" sounds more appropriate > > So then should we replace all the osc_33m_clk names with osc_clk? This patch only modifies one name and it looks like a clkdev lookup is created that still has osc_33m_clk for the connection name in drivers/clk/clk-ls1x.c, so merging it would mean things break? I also wonder what the pin is actually called in the datasheet, because that should be what the cpufreq driver uses in clk_get() as the connection id. If that's osc_33m_clk then it's better to leave it alone even if the frequency is different. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
