Hi Florian, On Aug 13, 2016, at 8:24 AM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > > On 08/12/2016 01:52 AM, Jaedon Shin wrote: >> Adds SDHCI device nodes to BCM7xxx MIPS based SoCs. > > While this looks good, I don't think you will have working SDHCI > interfaces on the 7425/7435 without additional pinmuxing, because > sometimes the bootloader indicates in a scratch register whether the > SDHCI0 is usable and the default pinmuxing does not necessarily make > this possible: > > https://github.com/Broadcom/stblinux-3.3/blob/master/linux/drivers/brcmstb/board.c#L325 > > We have some currently out of tree patches using the pinctrl-single and > some CFE shim to fix that. > > Other than that: > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > -- > Florian Sure, It is need to set pinmux, scratch register, endian and avoid broken enable, but I think that is CFE's role. (eg. BCM7346 should be set the endian while run in little endian mode) If we cannot update the CFE, we should consider adding sun_top_ctrl_pin_mux and aon_pin_ctrl_pin_mux_ctrl in device tree with counterpart and endian patch in sdhci-brcmstb. Anyway, that's not the work of device tree. Thanks, Jaedon
