This series of commits is a part of a larger project to ensure
people don't reference modular support functions in non-modular
code. Overall there was roughly 5k lines of dead code in the
kernel due to this. So far we've fixed several areas, like tty,
x86, net, ... and we continue to work on other areas.
There are several reasons to not use module support for code that
can never be built as a module, but the big ones are:
(1) it is easy to accidentally write unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be
modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn
includes nearly everything else, thus adding to CPP overhead.
(4) it gets copied/replicated into other code and spreads like weeds.
This represents the drivers actually using modular functions; there are
also drivers/files that include module.h but don't use any of the macros
or functions within it. Those MIPS instances will be handled separately.
Paul.
---
Cc: Aurelien Jarno <aurelien@xxxxxxxxxxx>
Cc: Hauke Mehrtens <hauke@xxxxxxxxxx>
Cc: John Crispin <john@xxxxxxxxxxx>
Cc: "Rafał Miłecki" <zajec5@xxxxxxxxx>
Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Cc: linux-mips@xxxxxxxxxxxxxx
Paul Gortmaker (4):
mips: bcm47xx: make serial explicitly non-modular
mips: ralink: make timer explicitly non-modular
mips: lantiq: make vmmc explicitly non-modular
mips: lantiq: make xrx200_phy_fw explicitly non-modular
arch/mips/bcm47xx/serial.c | 11 ++++-------
arch/mips/lantiq/xway/vmmc.c | 6 ++----
arch/mips/lantiq/xway/xrx200_phy_fw.c | 12 ++++--------
arch/mips/ralink/timer.c | 28 +++++++---------------------
4 files changed, 17 insertions(+), 40 deletions(-)
--
2.8.4
