Re: [PATCH 2/4] MIPS: BMIPS: Add support GPIO device nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonas,

On Aug 9, 2016, at 11:14 PM, Jonas Gorski <jonas.gorski@xxxxxxxxx> wrote:
> 
> Hi,
> 
> On 9 August 2016 at 03:44, Jaedon Shin <jaedon.shin@xxxxxxxxx> wrote:
>> Hi Jonas,
>> 
>> On Aug 8, 2016, at 11:06 PM, Jonas Gorski <jonas.gorski@xxxxxxxxx> wrote:
>>> 
>>> Hi,
>>> 
>>> please always include devicetree for any dts(i) related changes.
>>> 
>>> On 8 August 2016 at 04:17, Jaedon Shin <jaedon.shin@xxxxxxxxx> wrote:
>>>> (snip)
>>>> diff --git a/arch/mips/boot/dts/brcm/bcm97435svmb.dts b/arch/mips/boot/dts/brcm/bcm97435svmb.dts
>>>> index 9db84f2a6664..dd8b8fb97053 100644
>>>> --- a/arch/mips/boot/dts/brcm/bcm97435svmb.dts
>>>> +++ b/arch/mips/boot/dts/brcm/bcm97435svmb.dts
>>>> @@ -59,6 +59,14 @@
>>>>       status = "okay";
>>>> };
>>>> 
>>>> +&upg_gio {
>>>> +       status = "okay";
>>>> +};
>>>> +
>>>> +&upg_gio_aon {
>>>> +       status = "okay";
>>>> +};
>>>> +
>>> 
>>> You don't set their status in the dtsi, they will be enabled by
>>> default, and you can drop this change.
>>> 
>>>> &enet0 {
>>>>       status = "okay";
>>>> };
>>> 
>>> 
>>> Regards
>>> Jonas
>> 
>> The status="disabled" has been missing. It will be added in v2.
>> The interrupt-controller@ will also be changed.
> 
> I thought that was indented, since GPIO controllers usually are always
> present (you don't disable the irq controllers by default either).
> 
> Not that I want to tell you how you do your dts(i) files, but I would
> expect things that you usually always need (irq, clocks, gpios) are
> present by default.
> 
> 
> Regards
> Jonas

I checked the BCM7445 ARM based SoC device tree and other BRCM boards, and
I agree with your point. The status="okay" nodes will be removed in v2.

Thanks,
Jaedon



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux