Re: [PATCH 8/9] MIPS: KVM: Decode RDHWR more strictly

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

On 07/05/2016 03:39 PM, Paolo Bonzini wrote:

> > >      if (inst.r_format.opcode == spec3_op &&
> > > -        inst.r_format.func == rdhwr_op) {
> > > +        inst.r_format.func == rdhwr_op &&
> > > +        inst.r_format.rs == 0 &&
> > > +        (inst.r_format.re >> 3) == 0) {
> >
> >    Inner parens not necessary here.
>
> They are nicer though.

   I wouldn't say so...

> Paolo

MBR, Sergei