Re: [PATCH 2/2] MIPS: store the appended dtb address in a variable

[Daniel Gimpelevich <daniel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, 2016-06-17 at 14:07 +0200, Jonas Gorski wrote:
> +++ b/arch/mips/pic32/pic32mzda/init.c
> @@ -33,8 +33,8 @@ static ulong get_fdtaddr(void)
>  {
>         ulong ftaddr = 0;
>  
> -       if ((fw_arg0 == -2) && fw_arg1 && !fw_arg2 && !fw_arg3)
> -               return (ulong)fw_arg1;
> +       if (fw_passed_dtb && !fw_arg2 && !fw_arg3)
> +               return (ulong)fw_passed_dtb;

This part potentially violates the UHI spec. If fw_passed_dtb is valid
but fw_arg0 > 0, fw_arg2 may still be a valid envp. Comparing otherwise
undefined values to zero is also incorrect.