Re: [RFC PATCH] Re: Adding support for device tree and command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 24 May 2016 08:27:30 -0700
Daniel Gimpelevich <daniel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 2016-05-24 at 08:15 -0700, Daniel Gimpelevich wrote:
> > On Tue, 2016-05-24 at 14:27 +0300, Antony Pavlov wrote:
> > > We have too many 0xd00dfeed.
> > > Can we introduce some macro aliases, like
> > > arch/arm/kernel/head-common.S does?
> > > Something like this
> > > 
> > > #define OF_DT_MAGIC 0xd00dfeed
> > 
> > And exactly where would you propose to put that? Having the same #define
> > in multiple places is no better than just using the value…
> 
> Never mind. It's already in <linux/of_fdt.h>. I will supersede this
> after making any additional requested changes. What else needs to
> change?

Also we can drop '#if defined(CONFIG_*' in favour of 'if (IS_ENABLED(CONFIG_*'.

-- 
Best regards,
  Antony Pavlov




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux