Re: [PATCH] MIPS: Fix write_gc0_* macros when writing zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 18 May 2016, James Hogan wrote:

> The versions of the __write_{32,64}bit_gc0_register() macros for when
> there is no virt support in the assembler use the "J" inline asm
> constraint to allow integer zero, but this needs to be accompanied by
> the "z" formatting string so that it turns into $0. Fix both macros to
> do this.

 NB `z' here is an "operand code" in GCC-speak.  There's a list of the 
MIPS-specific ones in gcc/config/mips/mips.c above `mips_print_operand'.  
There are a few generic operand codes as well, most notably `a' to print 
an address, matching the `p' constraint.  I think it would be good to have 
this all documented in the GCC manual sometime.

> Fixes: bad50d79255a ("MIPS: Fix VZ probe gas errors with binutils <2.24")
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> ---

Reviewed-by: Maciej W. Rozycki <macro@xxxxxxxxxx>

  Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux