On Fri, Apr 15, 2016 at 09:29:06PM +0100, James Hogan wrote: > Having had to work my way through some of this file to manually walk > page tables only this week, I really do think this is an excellent > cleanup (if nothing else, look at that diffstat :-D ). I agree. Lots of history in this file. It uses #define because well, i386 was using #define back in the 90's when Elvis was still alive. Much of the page table code has been rewritten for simplicity, performance and ease of maintenance but somehow this has escaped so far. And I'm wondering if eventually the rewrite should be taken even further making things fully dynamic. Ralf
