On 08-04-16, 19:42, Keguang Zhang wrote: > From: Kelvin Cheung <keguang.zhang@xxxxxxxxx> > > - Rename the file to loongson1-cpufreq.c > - Use kcalloc() instead of kzalloc() > - Use devm_kzalloc() instead of global structure > - Use dev_get_platdata() to access the platform_data field > instead of referencing it directly > - Remove superfluous error messages Its much better now, in the sense that I can see what you have done. And see you have done a lot. That's not how you are supposed to send the patches, sorry. You need to break this patch into multiple patches, each targeting a particular fix. And I have no idea now, what change you have done to make it work for Loongson1B. Which of the above changes does that? And please, just send out a separate cpufreq series and don't send everything in a single patchset that covers DMA, cpufreq, clk, etc.. -- viresh
