On 06-04-16, 20:34, Keguang Zhang wrote: > From: Kelvin Cheung <keguang.zhang@xxxxxxxxx> > > - Rename the file to loongson1-cpufreq.c > - Use kcalloc() instead of kzalloc() > - Use devm_kzalloc() instead of global structure > - Use dev_get_platdata() to access the platform_data field > instead of referencing it directly > - Remove superfluous error messages > > Signed-off-by: Kelvin Cheung <keguang.zhang@xxxxxxxxx> > --- > drivers/cpufreq/Makefile | 2 +- > drivers/cpufreq/loongson1-cpufreq.c | 230 ++++++++++++++++++++++++++++++++++++ > drivers/cpufreq/ls1x-cpufreq.c | 222 ---------------------------------- > 3 files changed, 231 insertions(+), 223 deletions(-) > create mode 100644 drivers/cpufreq/loongson1-cpufreq.c > delete mode 100644 drivers/cpufreq/ls1x-cpufreq.c This can't be reviewed. I am not going to compare them line by line to see what you might have changed in between. Please use '-C -M' options of git format-patch to generate this, it will give a review-able output of this. -- viresh
