On Wed, Mar 30, 2016 at 10:13:29PM +0300, Antony Pavlov wrote: > It is very strange because my original patch has this closing brace. > Please see my original patch > https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html The patch didn't apply cleanly and I botched resolving it, sorry. I folded the fix into the patch. > Also I suppose that we have no need in detect_memory_region() if we use devicetree, > e.g. > > ath79_detect_sys_type(); > ath79_ddr_ctrl_init(); > + detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); > + } > > - detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); "suppose" is a bit weak.. Should I move the detect_memory_region call? Ralf
