Re: [PATCH] Firmware: broadcom sprom: clarifiy SSB dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 March 2016 at 15:21, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> The broadcom firmware drvier calls into the ssb SPROM code if that
> is enabled, but it fails if the SSB code is in a loadable module
> because the bcm47xx firmware is always built-in:
>
> drivers/firmware/built-in.o: In function `bcm47xx_sprom_register_fallbacks':
> bcm47xx_sprom.c:(.text+0x11c4): undefined reference to `ssb_arch_register_fallback_sprom'
>
> This adds a Kconfig dependency to ensure that we cannot turn on the
> generic sprom support if the ssb sprom is in a module.

Can you attach your config that triggered this build error? I modified
condition to the:
#if IS_BUILTIN(CONFIG_SSB) && IS_ENABLED(CONFIG_SSB_SPROM)
which I believe should be enough.

I'm afraid your patch won't allow compiling SPROM driver with BCMA=y
and SSB as a module.




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux