Yes, you are right, I'll update the commit message. Huacai On Tue, Mar 1, 2016 at 9:06 AM, Maciej W. Rozycki <macro@xxxxxxxxxx> wrote: > On Thu, 25 Feb 2016, Huacai Chen wrote: > >> Yes, we can probe whether the platform support ei/di or not. But >> whether use ei/di is not depend on runtime flag, but depend on >> CONFIG_* in current kernel. So I have no idea how to use ei/di by >> probing. > > OK, I think I have a full picture now. > > There's no need to probe, but I think the commit description and config > text option are a bit misleading. This looks like the next architecture > revision to me, much like MIPS32r1 vs MIPS32r2 for example, and it is > quite normal that you don't probe for the new features it provides (even > though -- sticking to the example -- we could probe for MIPS32r2 > additions), but you just require whoever configures the kernel to choose > the intended setup. IOW it's a design decision rather than a technical > limitation. > > So may I suggest that you rewrite the relevant part of the help text to > read: > > "This option enables those enhancements which are not probed at run time." > > or suchlike? And then similarly in the commit description. > > Thanks, > > Maciej >
