Re: [PATCH] MIPS: tlbex: Fix bugs in tlbchange handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Feb 2016, Huacai Chen wrote:

> I *do* have answered your quesition, which you can see here:
> https://patchwork.linux-mips.org/patch/12240/
> 
> When unaligned access triggered, do_ade() will access user address
> with EXL=1, and that may trigger tlb refill.

 Thank you and I can see your original answer as well, which would need to 
go into the patch description itself, however it is too vague for me I'm 
afraid.

 Unaligned accesses have been likewise handled since forever and no one 
else has hit an issue with `do_ade' making user accesses with EXL=1, as 
this handler is only called once KMODE has cleared EXL.  So please explain 
us the scenario in which it doesn't happen and you still have EXL=1 in 
`do_ade'.  What the conditions for this to be the case?

 Without a further explanation it looks like a bug elsewhere to me, which 
needs to be treated accordingly there, rather than by complicating TLB 
handlers.

  Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux