Re: [PATCH] mips: Avoid a form of the .type directive that is not supported by LLVM's Integrated Assembler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 17, 2016 at 08:04:31PM +0000, Maciej W. Rozycki wrote:

>  If LLVM strives to be GNU toolchain compatible, then this looks like a 
> bug in their scanner as generic ELF support in GAS (gas/config/obj-elf.c) 
> has this, in `obj_elf_type':
> 
>   if (*input_line_pointer == ',')
>     ++input_line_pointer;
> 
> so the comma is entirely optional.  I realise this is undocumented, but 
> there you go.  It must have been there since forever.

It contradicts documentation.  The gas manual says:

* Type::                        `.type <INT | NAME , TYPE DESCRIPTION>'

And the SGI assembler manual I dug up as ".type name, value".  So maybe
gas is too generous here?

Either way, I think the patch is right and I've just applied v2.

  Ralf




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux