On Thu, 4 Feb 2016 11:06:30 +0100
Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote:
> The mtd_ooblayout_xxx() helper functions have been added to avoid direct
> accesses to the ecclayout field, and thus ease for future reworks.
> Use these helpers in all places where the oobfree[] and eccpos[] arrays
> where directly accessed.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/mtd/nand/nand_base.c | 169 ++++++++++++++++++-------------------------
> drivers/mtd/nand/nand_bch.c | 3 +-
> 2 files changed, 74 insertions(+), 98 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 572369d..e01a9b5 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
[...]
> @@ -4116,7 +4092,6 @@ static bool nand_ecc_strength_good(struct mtd_info *mtd)
> */
> int nand_scan_tail(struct mtd_info *mtd)
> {
> - int i;
> struct nand_chip *chip = mtd_to_nand(mtd);
> struct nand_ecc_ctrl *ecc = &chip->ecc;
> struct nand_buffers *nbuf;
> @@ -4315,9 +4290,9 @@ int nand_scan_tail(struct mtd_info *mtd)
> * The number of bytes available for a client to place data into
> * the out of band area.
> */
> - mtd->oobavail = 0;
> - for (i = 0; ecc->layout->oobfree[i].length; i++)
> - mtd->oobavail += ecc->layout->oobfree[i].length;
> + mtd->oobavail = mtd_ooblayout_count_freebytes(mtd);
We should call that after setting the mtd->ecclayout field.
> + if (mtd->oobavail < 0)
> + mtd->oobavail = 0;
>
> /* ECC sanity check: warn if it's too weak */
> if (!nand_ecc_strength_good(mtd))
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
