Re: [PATCH] MIPS: Octeon: Add Octeon III CN7XXX interface detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2016 09:52 AM, Sergei Shtylyov wrote:
On 02/03/2016 08:45 PM, Zubair Lutfullah Kakakhel wrote:

Add basic CN7XXX interface detection.

This allows the kernel to boot with ethernet working as it initializes
the ethernet ports with SGMII instead of defaulting to RGMII routines.

Tested on the utm8 from Rhino Labs with a CN7130.

Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@xxxxxxxxxx>
---
  arch/mips/cavium-octeon/executive/cvmx-helper.c | 41
+++++++++++++++++++++++++
  1 file changed, 41 insertions(+)

diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper.c
b/arch/mips/cavium-octeon/executive/cvmx-helper.c
index 376701f..1a28009 100644
--- a/arch/mips/cavium-octeon/executive/cvmx-helper.c
+++ b/arch/mips/cavium-octeon/executive/cvmx-helper.c
[...]
@@ -260,6 +262,39 @@ static cvmx_helper_interface_mode_t
__cvmx_get_mode_octeon2(int interface)
  }

  /**
+ * @INTERNAL
+ * Return interface mode for CN7XXX.
+ */
+static cvmx_helper_interface_mode_t __cvmx_get_mode_cn7xxx(int
interface)

    Not *unsigned*?

The rest of the instances in the file don't have unsigned.

Probably because it is an enum..

    I meant the parameter, of course.


In this file, the "interface" is consistently given the type int. Check it out, it is int everywhere.

I think it makes sense to maintain consistency and use int here too.

David Daney


[...]

(⌐▀͡ ̯ʖ▀)

Thanks
ZubairLK

[...]

MBR, Sergei






[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux