Avoid a reader's confusion, as the calculation is correct either way. Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxx> --- linux-umips-dsemul-addiupc-nit.diff Index: linux-sfr-test/arch/mips/math-emu/dsemul.c =================================================================== --- linux-sfr-test.orig/arch/mips/math-emu/dsemul.c 2016-01-29 14:11:03.000000000 +0000 +++ linux-sfr-test/arch/mips/math-emu/dsemul.c 2016-01-29 14:13:53.613960000 +0000 @@ -60,7 +60,7 @@ int mips_dsemul(struct pt_regs *regs, mi unsigned int rs; s32 v; - rs = (((insn.mm_a_format.rs + 0x1e) & 0xf) + 2); + rs = (((insn.mm_a_format.rs + 0xe) & 0xf) + 2); v = regs->cp0_epc & ~3; v += insn.mm_a_format.simmediate << 2; regs->regs[rs] = (long)v;