Correct formatting breakage introduced with commit 102cedc32a6e ("MIPS: microMIPS: Floating point support."), so that further changes to this code can be consistent. Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxx> --- Ralf, Please apply; as I noted in 0/7 the structure of this code would become inconsistent with the next change or the change itself would have to break our formatting rules, to say nothing of legibility. Consequently this change needs backporting to stable branches so that 3/7 can be backported as well. I'm all but happy about the style of this code itself BTW, the chains of casts of casts are not really needed, but I'll save a further clean-up for another day. Maciej linux-umips-dsemul-format.diff Index: linux-sfr-sead/arch/mips/math-emu/dsemul.c =================================================================== --- linux-sfr-sead.orig/arch/mips/math-emu/dsemul.c 2016-01-22 01:21:57.194943000 +0000 +++ linux-sfr-sead/arch/mips/math-emu/dsemul.c 2016-01-22 01:57:12.640605000 +0000 @@ -75,10 +75,14 @@ int mips_dsemul(struct pt_regs *regs, mi return SIGBUS; if (get_isa16_mode(regs->cp0_epc)) { - err = __put_user(ir >> 16, (u16 __user *)(&fr->emul)); - err |= __put_user(ir & 0xffff, (u16 __user *)((long)(&fr->emul) + 2)); - err |= __put_user(BREAK_MATH >> 16, (u16 __user *)(&fr->badinst)); - err |= __put_user(BREAK_MATH & 0xffff, (u16 __user *)((long)(&fr->badinst) + 2)); + err = __put_user(ir >> 16, + (u16 __user *)(&fr->emul)); + err |= __put_user(ir & 0xffff, + (u16 __user *)((long)(&fr->emul) + 2)); + err |= __put_user(BREAK_MATH >> 16, + (u16 __user *)(&fr->badinst)); + err |= __put_user(BREAK_MATH & 0xffff, + (u16 __user *)((long)(&fr->badinst) + 2)); } else { err = __put_user(ir, &fr->emul); err |= __put_user((mips_instruction)BREAK_MATH, &fr->badinst); @@ -125,8 +129,10 @@ int do_dsemulret(struct pt_regs *xcp) * - Is the following memory word the BD_COOKIE? */ if (get_isa16_mode(xcp->cp0_epc)) { - err = __get_user(instr[0], (u16 __user *)(&fr->badinst)); - err |= __get_user(instr[1], (u16 __user *)((long)(&fr->badinst) + 2)); + err = __get_user(instr[0], + (u16 __user *)(&fr->badinst)); + err |= __get_user(instr[1], + (u16 __user *)((long)(&fr->badinst) + 2)); insn = (instr[0] << 16) | instr[1]; } else { err = __get_user(insn, &fr->badinst);