On Mon, 18 Jan 2016 20:57:25 +0100
Alban <albeu@xxxxxxx> wrote:
> On Mon, 18 Jan 2016 02:56:24 +0300
> Antony Pavlov <antonynpavlov@xxxxxxxxx> wrote:
>
> > At the moment ar933x of-enabled drivers use use clock names
> > (e.g. "uart" or "ahb") to get clk descriptor.
> > On the other hand
> > Documentation/devicetree/bindings/clock/clock-bindings.txt states
> > that the 'clocks' property is required for passing clk to clock
> > consumers.
>
> This patch is not need, you should set the clock-names property in
> the relevant device nodes instead.
This patch is needed for AR9331!
In ar933x_clocks_init() we have
ath79_add_sys_clkdev("ref", ref_rate);
clks[0] = ath79_add_sys_clkdev("cpu", cpu_rate);
clks[1] = ath79_add_sys_clkdev("ddr", ddr_rate);
clks[2] = ath79_add_sys_clkdev("ahb", ahb_rate);
clk_add_alias("wdt", NULL, "ahb", NULL);
clk_add_alias("uart", NULL, "ref", NULL);
"uart" is an alias for "ref". But "ref" is not visible via device tree!
I see this error message on ar933x-uart start:
ERROR: could not get clock /ahb/apb/uart@18020000:uart(0)
--
Best regards,
Antony Pavlov
