On Fri, 15 Jan 2016 10:48:21 -0800
David Daney <ddaney.cavm@xxxxxxxxx> wrote:
> On 01/14/2016 12:20 AM, Antony Pavlov wrote:
> > The correct name for aliases node is "aliases" not "alias".
> >
> > An overview of the "aliases" node usage can be found
> > on the device tree usage page at devicetree.org [1].
> >
> > Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
> >
> > [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> > [2] https://www.power.org/documentation/epapr-version-1-1/
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx>
> > Cc: Alban Bedel <albeu@xxxxxxx>
> > Cc: linux-mips@xxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > ---
> > arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > index 003015a..4b6d38c 100644
> > --- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > @@ -9,7 +9,7 @@
> > compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> > model = "TP-Link TL-WR1043ND Version 1";
> >
> > - alias {
> > + aliases {
> > serial0 = "/ahb/apb/uart@18020000";
> > };
>
> What uses this alias? If the answer is nothing (likely, as it was
> broken and nobody seems to have noticed), just remove the whole thing.
I have used ar9132_tl_wr1043nd_v1.dts as a template for AR9331-based board dts-file.
AR9331 uses it's own very special UART implementation (the ar933x_uart.c driver is used).
ar933x_uart.c relies on alias and does not work if alias is not set.
I have not yet runned linux on TL-WR1034ND, but I suppose that uart alias is not
actually used for TL-WR1034ND and this aliases node can be safely removed.
Alban, have you any comments?
--
Best regards,
Antony Pavlov
