On Wed, 13 Jan 2016, Joshua Henderson wrote:
> +static int pic32_set_type_edge(struct irq_data *data,
> + unsigned int flow_type)
> +{
> + struct evic_chip_data *priv = irqd_to_priv(data);
> + int ret;
> + int i;
> +
> + if (!(flow_type & IRQ_TYPE_EDGE_BOTH))
> + return -EBADR;
> +
> + /* set polarity for external interrupts only */
> + for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) {
> + if (priv->ext_irqs[i] == data->hwirq) {
> + ret = pic32_set_ext_polarity(i + 1, flow_type);
> + if (ret)
> + return ret;
> + }
> + }
> +
> + irqd_set_trigger_type(data, flow_type);
The core code handles that already.
> +static int pic32_irq_domain_map(struct irq_domain *d, unsigned int virq,
> + irq_hw_number_t hw)
> +{
> + struct evic_chip_data *priv = d->host_data;
> + struct irq_data *data;
> + int ret;
> + u32 iecclr, ifsclr;
> + u32 reg, mask;
> +
> + ret = irq_map_generic_chip(d, virq, hw);
> + if (ret)
> + return ret;
> +
> + /*
> + * Piggyback on xlate function to move to an alternate chip as necessary
> + * at time of mapping instead of allowing the flow handler/chip to be
> + * changed later. This requires all interrupts to be configured through
> + * DT.
> + */
> + if (priv->irq_types[hw] & IRQ_TYPE_SENSE_MASK) {
> + data = irq_domain_get_irq_data(d, virq);
> + irqd_set_trigger_type(data, priv->irq_types[hw]);
> + irq_setup_alt_chip(data, priv->irq_types[hw]);
> + }
I like that approach.
So except for the nit in pic32_set_type_edge() this looks good. It's pretty
clear now what the code does and how the hardware works.
Thanks for following up!
tglx
