linux-4.4-rc8/arch/mips/include/asm/netlogic/xlr/fmn.h:304: bad test ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello there,

[linux-4.4-rc8/arch/mips/include/asm/netlogic/xlr/fmn.h:304]: (style) Expression '(X & 0x2) == 0x1' is always false.

Source code is

    if ((status & 0x2) == 1)
            pr_info("Send pending fail!\n");

Maybe better code

    if ((status & 0x2) != 0)
            pr_info("Send pending fail!\n");

Regards

David Binderman

 		 	   		  



[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux