Re: [PATCH] Fix ld-version.sh to handle large 3rd version part

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 26, 2015 at 10:47:52PM +0000, James Hogan wrote:
> The ld-version.sh script doesn't handle versions with large (>= 10) 3rd
> version components, because the 2nd component is only multiplied by 10
> times that of the 3rd component.
> 
> For example the following version string:
> GNU ld (Codescape GNU Tools 2015.06-05 for MIPS MTI Linux) 2.24.90
> 
> gives a bogus version number:
>  20000000
> + 2400000
> +  900000 = 23300000
> 
> Breakage, confusion and mole-whacking ensues.

Thanks. Looks good. I'll fix the LTO tree.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux