On Mon, Nov 30, 2015 at 04:21:27PM +0000, Paul Burton wrote: > Add documentation for a devicetree binding for simple memory-mapped > ASCII LCD displays, such as those found on the Imagination Technologies > Boston & Malta development boards. > > Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx> > --- > > Documentation/devicetree/bindings/ascii-lcd.txt | 10 ++++++++++ This should go under bindings/display/. > MAINTAINERS | 5 +++++ > 2 files changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ascii-lcd.txt > > diff --git a/Documentation/devicetree/bindings/ascii-lcd.txt b/Documentation/devicetree/bindings/ascii-lcd.txt > new file mode 100644 > index 0000000..40ae536 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ascii-lcd.txt > @@ -0,0 +1,10 @@ > +Binding for simple memory-mapped ASCII LCD displays Presumably, this is a binding for the controller, not the actual display. You need to more fully describe what the h/w looks like here. Like what is the interface between the controller and display? Rob > + > +Required properties: > +- compatible : should be one of: > + "img,boston-lcd" > + "mti,malta-lcd" > +- reg : memory region locating the device registers > + > +The layout of the registers & properties of the display are determined > +from the compatible string, making this binding somewhat trivial. > diff --git a/MAINTAINERS b/MAINTAINERS > index cba790b..1e2b74b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1782,6 +1782,11 @@ S: Maintained > F: Documentation/hwmon/asc7621 > F: drivers/hwmon/asc7621.c > > +ASCII LCD DRIVER > +M: Paul Burton <paul.burton@xxxxxxxxxx> > +S: Maintained > +F: Documentation/devicetree/bindings/ascii-lcd.txt > + > ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS > M: Corentin Chary <corentin.chary@xxxxxxxxx> > L: acpi4asus-user@xxxxxxxxxxxxxxxxxxxxx > -- > 2.6.2 >
