Re: [PATCH 1/2] MIPS: BCM47xx: Support on-SoC bus in SPROM reading function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/25/2015 10:16 PM, Rafał Miłecki wrote:
> To support (extract) SPROM on Broadcom ARM devices we should separate
> SPROM code and make it a separated module. We won't want to export
> bcm47xx_fill_sprom symbol so we should support SoC SPROM in the standard
> fallback function and then modify ssb to use it.
> 
> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>

Acked-by: Hauke Mehrtens <hauke@xxxxxxxxxx>

> ---
>  arch/mips/bcm47xx/sprom.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/bcm47xx/sprom.c b/arch/mips/bcm47xx/sprom.c
> index 2d5c7a7..e19c1b9 100644
> --- a/arch/mips/bcm47xx/sprom.c
> +++ b/arch/mips/bcm47xx/sprom.c
> @@ -610,14 +610,18 @@ static int bcm47xx_get_sprom_ssb(struct ssb_bus *bus, struct ssb_sprom *out)
>  {
>  	char prefix[10];
>  
> -	if (bus->bustype == SSB_BUSTYPE_PCI) {
> +	switch (bus->bustype) {
> +	case SSB_BUSTYPE_SSB:
> +		bcm47xx_fill_sprom(out, NULL, false);
> +		return 0;
> +	case SSB_BUSTYPE_PCI:
>  		memset(out, 0, sizeof(struct ssb_sprom));
>  		snprintf(prefix, sizeof(prefix), "pci/%u/%u/",
>  			 bus->host_pci->bus->number + 1,
>  			 PCI_SLOT(bus->host_pci->devfn));
>  		bcm47xx_fill_sprom(out, prefix, false);
>  		return 0;
> -	} else {
> +	default:
>  		pr_warn("Unable to fill SPROM for given bustype.\n");
>  		return -EINVAL;
>  	}
> 





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux