2015-10-22 18:44 GMT-07:00 Jaedon Shin <jaedon.shin@xxxxxxxxx>:
> Add data of device node for port offset.
Looks good to me, some minor nits below.
>
> Signed-off-by: Jaedon Shin <jaedon.shin@xxxxxxxxx>
> ---
> drivers/ata/ahci_brcmstb.c | 25 +++++++++++++++++--------
> 1 file changed, 17 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/ata/ahci_brcmstb.c b/drivers/ata/ahci_brcmstb.c
> index 14b7305d2ba0..8cf6f7d4798f 100644
> --- a/drivers/ata/ahci_brcmstb.c
> +++ b/drivers/ata/ahci_brcmstb.c
> @@ -72,6 +72,7 @@
> struct brcm_ahci_priv {
> struct device *dev;
> void __iomem *top_ctrl;
> + u32 port_offset;
> u32 port_mask;
> };
>
> @@ -110,7 +111,7 @@ static inline void brcm_sata_writereg(u32 val, void __iomem *addr)
> static void brcm_sata_phy_enable(struct brcm_ahci_priv *priv, int port)
> {
> void __iomem *phyctrl = priv->top_ctrl + SATA_TOP_CTRL_PHY_CTRL +
> - (port * SATA_TOP_CTRL_PHY_OFFS);
> + (port * priv->port_offset);
> void __iomem *p;
> u32 reg;
>
> @@ -139,7 +140,7 @@ static void brcm_sata_phy_enable(struct brcm_ahci_priv *priv, int port)
> static void brcm_sata_phy_disable(struct brcm_ahci_priv *priv, int port)
> {
> void __iomem *phyctrl = priv->top_ctrl + SATA_TOP_CTRL_PHY_CTRL +
> - (port * SATA_TOP_CTRL_PHY_OFFS);
> + (port * priv->port_offset);
> void __iomem *p;
> u32 reg;
>
> @@ -234,6 +235,13 @@ static int brcm_ahci_resume(struct device *dev)
> }
> #endif
>
> +static const struct of_device_id ahci_of_match[] = {
> + {.compatible = "brcm,bcm7445-ahci",
> + .data = (void *)SATA_TOP_CTRL_PHY_OFFS},
We could omit having to specify explicitly the offset here.
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, ahci_of_match);
> +
> static struct scsi_host_template ahci_platform_sht = {
> AHCI_SHT(DRV_NAME),
> };
> @@ -241,6 +249,7 @@ static struct scsi_host_template ahci_platform_sht = {
> static int brcm_ahci_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> + const struct of_device_id *of_id = NULL;
> struct brcm_ahci_priv *priv;
> struct ahci_host_priv *hpriv;
> struct resource *res;
> @@ -256,6 +265,12 @@ static int brcm_ahci_probe(struct platform_device *pdev)
> if (IS_ERR(priv->top_ctrl))
> return PTR_ERR(priv->top_ctrl);
>
> + of_id = of_match_node(ahci_of_match, dev->of_node);
> + if (!of_id)
> + return -EINVAL;
> +
> + priv->port_offset = (u32)of_id->data;
And if of_id->data is NULL here, just default to
SATA_TOP_CTRL_PHY_OFFS. But I have no strong preference.
