On Tue, 15 Sep 2015 17:50:53 -0700 Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > > > > __iowrite32_copy() is marked __visible. I don't actually know what > > that does and Andi's d47d5c8194579bc changelog (which sucks the big > > one) didn't explain it. Apparently it has something to do with being > > implemented in assembly, but zillions of functions are implemented in > > assembly, so why are only two functions marked this way? Anyway, > > __ioread32_copy() is implemented in C so I guess __visible isn't needed > > there. > > Yeah, I didn't add visible because there isn't an assembly > version of __ioread32_copy() so far. I can remove __weak if > desired. I left it there to match __iowrite32_copy() in case > x86 wanted to override it but we can do that later or never. OK. I'd omit the __weak and __visible for now. They can be added later if someone needs them.
