Re: [PATCH] MIPS: UAPI: Disable __arch_swab{16,32} when using MIPS16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 7 Sep 2015, Yousong Zhou wrote:

> index 8f2d184..8396d5a 100644
> --- a/arch/mips/include/uapi/asm/swab.h
> +++ b/arch/mips/include/uapi/asm/swab.h
> @@ -16,6 +16,10 @@
>  #if (defined(__mips_isa_rev) && (__mips_isa_rev >= 2)) ||		\
>      defined(_MIPS_ARCH_LOONGSON3A)
>  
> +/*
> + * Enable the optimized version only when compiling without MIPS16.
> + */
> +#ifndef __mips16
>  static inline __attribute_const__ __u16 __arch_swab16(__u16 x)
>  {
>  	__asm__(
> @@ -44,6 +48,7 @@ static inline __attribute_const__ __u32 __arch_swab32(__u32 x)
>  	return x;
>  }
>  #define __arch_swab32 __arch_swab32
> +#endif /* ifndef __mips16 */
>  
>  /*
>   * Having already checked for MIPS R2, enable the optimized version for

 Please #ifdef-out all the functions, there's nothing about
`__arch_swab64' making it worth being a special exception.

  Maciej




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux