On Thu, 3 Sep 2015 05:34:21 +0200
Alexander Couzens <lynxis@xxxxxxx> wrote:
> The irq ack handler was forgotten while introducing OF support.
> Only ar71xx and ar933x based devices require it.
>
> Signed-off-by: Alexander Couzens <lynxis@xxxxxxx>
> ---
> arch/mips/ath79/irq.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c
> index afb0096..1917f55 100644
> --- a/arch/mips/ath79/irq.c
> +++ b/arch/mips/ath79/irq.c
> @@ -308,8 +308,17 @@ static int __init ath79_misc_intc_of_init(
>
> return 0;
> }
> -IRQCHIP_DECLARE(ath79_misc_intc, "qca,ar7100-misc-intc",
> - ath79_misc_intc_of_init);
> +
> +static int __init ar7100_misc_intc_of_init(
> + struct device_node *node, struct device_node *parent)
> +{
> + pr_info("IRQ: Setup ar7100 misc IRQ controller from devicetree.\n");
Debug left over?
> + ath79_misc_irq_chip.irq_mask_ack = ar71xx_misc_irq_mask;
> + return ath79_misc_intc_of_init(node, parent);
> +}
> +
> +IRQCHIP_DECLARE(ar7100_misc_intc, "qca,ar7100-misc-intc",
> + ar7100_misc_intc_of_init);
>
> static int __init ar79_cpu_intc_of_init(
> struct device_node *node, struct device_node *parent)
Otherwise that looks good.
Alban
