On Thu, 6 Aug 2015 12:43:24 +0200 Alexander Couzens <lynxis@xxxxxxx> wrote: A log message would be nice. IMHO it should mention that the ACK callbacks have been missed when introducing OF support. > Signed-off-by: Alexander Couzens <lynxis@xxxxxxx> > --- > arch/mips/ath79/irq.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/ath79/irq.c b/arch/mips/ath79/irq.c > index afb0096..dc76fa1 100644 > --- a/arch/mips/ath79/irq.c > +++ b/arch/mips/ath79/irq.c > @@ -303,13 +303,20 @@ static int __init ath79_misc_intc_of_init( > __raw_writel(0, base + AR71XX_RESET_REG_MISC_INT_ENABLE); > __raw_writel(0, base + AR71XX_RESET_REG_MISC_INT_STATUS); > > - I would prefer to see this in another patch. [...] Alban