Re: [PATCH v2] LED/MIPS: Move SEAD3 LED driver to where it belongs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ralf, Sergei,

On 08/03/2015 05:33 PM, Sergei Shtylyov wrote:
Hello.

On 08/03/2015 06:04 PM, Ralf Baechle wrote:

Fixes the following randconfig problem

leds-sead3.c:(.text+0x7dc): undefined reference to
`led_classdev_unregister'
leds-sead3.c:(.text+0x7e8): undefined reference to
`led_classdev_unregister'

Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
Cc: Bryan Wu <cooloney@xxxxxxxxx>
Cc: Richard Purdie <rpurdie@xxxxxxxxx>
Cc: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
Cc: Markos Chandras <markos.chandras@xxxxxxxxxx>
Cc: linux-leds@xxxxxxxxxxxxxxx
Cc: linux-mips@xxxxxxxxxxxxxx

[...]

diff --git a/arch/mips/mti-sead3/leds-sead3.c b/drivers/leds/leds-sead3.c
similarity index 99%
rename from arch/mips/mti-sead3/leds-sead3.c
rename to drivers/leds/leds-sead3.c
index c938cee..eb97a32 100644
--- a/arch/mips/mti-sead3/leds-sead3.c
+++ b/drivers/leds/leds-sead3.c

     Oh, so you started to use -M finally. :-)

@@ -59,6 +59,7 @@ static int sead3_led_remove(struct platform_device
*pdev)
  {
      led_classdev_unregister(&sead3_pled);
      led_classdev_unregister(&sead3_fled);
+

    Unrelated white space change?

Ralf, please split this change to the separate patch.
You could also reorder include directives to be arranged in
an alphabetical order.

      return 0;
  }

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
Best Regards,
Jacek Anaszewski




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux