On 07/14/2015 12:57 PM, Jonas Gorski wrote: > Hi, > > On Tue, Jul 14, 2015 at 11:26 AM, Markos Chandras > <markos.chandras@xxxxxxxxxx> wrote: >> Previously, the GIC accessors were only accessing u32 registers but >> newer CMs may actually be 64-bit on MIPS64 cores. As a result of which, >> extended these accessors to support 64-bit reads and writes. > > Have you tested this with a 32-bit build? IIRC the *q accessors are > only available on 64-bit builds. > > > Jonas > Yes but mips_cm_is64 is 0 for 32-bit kernels (see https://patchwork.linux-mips.org/patch/10707/) so it does not matter. but mips implements *q for 32-bit in arch/mips/include/asm/io.h anyway -- markos
