Re: [PATCH 07/14] MIPS/cevt-r4k: Migrate to new 'set-state' interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/06/2015 09:24 PM, Sergei Shtylyov wrote:

Migrate cevt-4k driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

We weren't doing anything in the ->set_mode() callback. So, this patch
doesn't provide any set-state callbacks.

    The code in __clockevents_switch_state() looks like it's going to oops as
you're not implementing set_state_oneshot()...

    In fact, clockevents_sanity_check() should return -EINVAL in this case,
and so the kernel crash even earlier, duyr to BUG_ON() in
clockevents_register_device().

tglx has turned my attention the pre-requisite patch, and I have finally found it in the archives. I'm now OK with the patches I considered broken.

WBR, Sergei





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux