Am 30.04.2015 um 13:50 schrieb Paolo Bonzini: > > > On 30/04/2015 13:43, Christian Borntraeger wrote: >> +/* must be called with irqs disabled */ >> +static inline void __kvm_guest_enter(void) >> { >> - unsigned long flags; >> - >> - BUG_ON(preemptible()); > > Please keep the BUG_ON() in kvm_guest_enter. Otherwise looks good, thanks! would be BUG_ON(!irqs_disabled()) then?