On 04/29/2015 10:49 AM, Maciej W. Rozycki wrote: > On Wed, 29 Apr 2015, James Hogan wrote: > >>> Error recovery pointers for fixups was improperly set as ".word" >>> which is unsuitable for MIPS64. >>> >>> Replaced by __stringify(PTR) >> >> Every other case of this sort of thing uses STR(PTR) (or __UA_ADDR in >> uaccess.h). Can we stick to STR(PTR) for consistency please? > > Or __PA_ADDR in paccess.h. > > I have mixed feelings, the reason for __stringify being absent is the > macro being generic and more recently added than pieces of code that use > STR, e.g. unaligned.c that has been there since forever. And we do use > __stringify in many other cases. > > On the other hand STR is short and sweet, unlike __stringify. The patch overall looks good to me so here is my Reviewed-by: Markos Chandras <markos.chandras@xxxxxxxxxx> I do agree with James that it would be nice to have it in stable 4.0+ as well. I don't particularly care if STR() is going to be used at the end or we stick to __stringify. Both are used in arch/mips/* anyway -- markos
