Re: [PATCH 2/2] ttyFDC: Fix to use native endian MMIO reads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 28, 2015 at 10:57:30AM +0100, James Hogan wrote:
> The MIPS Common Device Memory Map (CDMM) is internal to the core and has
> native endianness. There is therefore no need to byte swap the accesses
> on big endian targets, so convert the Fast Debug Channel (FDC) TTY
> driver to use __raw_readl()/__raw_writel() rather than
> ioread32()/iowrite32().
> 
> Fixes: 4cebec609aea ("TTY: Add MIPS EJTAG Fast Debug Channel TTY driver")
> Fixes: c2d7ef51d731 ("ttyFDC: Implement KGDB IO operations.")
> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> ---
>  drivers/tty/mips_ejtag_fdc.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux