Re: [PATCH] MIPS: asm: asmmacro: Ensure 64-bit FP registers are used with MSA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 16, 2015 at 11:05:59AM +0100, Markos Chandras wrote:
> This silences warnings like the following one when building with the
> latest binutils:

It may be helpful to refer to the versions of binutils which are
affected in the commit message.

> 
> arch/mips/kernel/genex.S: Assembler messages:
> arch/mips/kernel/genex.S:438: Warning: the `msa' extension requires 64-bit FPRs
> 
> Cc: James Hogan <james.hogan@xxxxxxxxxx>

Other than that,

Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>

Cheers
James

> Cc: Paul Burton <paul.burton@xxxxxxxxxx>
> Signed-off-by: Markos Chandras <markos.chandras@xxxxxxxxxx>
> ---
>  arch/mips/include/asm/asmmacro.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/mips/include/asm/asmmacro.h b/arch/mips/include/asm/asmmacro.h
> index 6156ac8c4cfb..76317a70200d 100644
> --- a/arch/mips/include/asm/asmmacro.h
> +++ b/arch/mips/include/asm/asmmacro.h
> @@ -211,9 +211,13 @@
>  	.endm
>  
>  #ifdef TOOLCHAIN_SUPPORTS_MSA
> +/* preprocessor replaces the fp in ".set fp=64" with $30 otherwise */
> +#undef fp
> +
>  	.macro	_cfcmsa	rd, cs
>  	.set	push
>  	.set	mips32r2
> +	.set	fp=64
>  	.set	msa
>  	cfcmsa	\rd, $\cs
>  	.set	pop
> @@ -222,6 +226,7 @@
>  	.macro	_ctcmsa	cd, rs
>  	.set	push
>  	.set	mips32r2
> +	.set	fp=64
>  	.set	msa
>  	ctcmsa	$\cd, \rs
>  	.set	pop
> @@ -230,6 +235,7 @@
>  	.macro	ld_d	wd, off, base
>  	.set	push
>  	.set	mips32r2
> +	.set	fp=64
>  	.set	msa
>  	ld.d	$w\wd, \off(\base)
>  	.set	pop
> @@ -238,6 +244,7 @@
>  	.macro	st_d	wd, off, base
>  	.set	push
>  	.set	mips32r2
> +	.set	fp=64
>  	.set	msa
>  	st.d	$w\wd, \off(\base)
>  	.set	pop
> @@ -246,6 +253,7 @@
>  	.macro	copy_u_w	ws, n
>  	.set	push
>  	.set	mips32r2
> +	.set	fp=64
>  	.set	msa
>  	copy_u.w $1, $w\ws[\n]
>  	.set	pop
> @@ -254,6 +262,7 @@
>  	.macro	copy_u_d	ws, n
>  	.set	push
>  	.set	mips64r2
> +	.set	fp=64
>  	.set	msa
>  	copy_u.d $1, $w\ws[\n]
>  	.set	pop
> @@ -262,6 +271,7 @@
>  	.macro	insert_w	wd, n
>  	.set	push
>  	.set	mips32r2
> +	.set	fp=64
>  	.set	msa
>  	insert.w $w\wd[\n], $1
>  	.set	pop
> @@ -270,6 +280,7 @@
>  	.macro	insert_d	wd, n
>  	.set	push
>  	.set	mips64r2
> +	.set	fp=64
>  	.set	msa
>  	insert.d $w\wd[\n], $1
>  	.set	pop
> -- 
> 2.3.4
> 

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux