Re: [PATCH V2] MIPS: Loongson: Naming style cleanup and rework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Really? I have seen many patches with their changelog in commit messages.

Huacai

On Tue, Apr 21, 2015 at 5:38 PM, Markos Chandras
<Markos.Chandras@xxxxxxxxxx> wrote:
> Hi,
>
> On 04/21/2015 03:00 AM, Huacai Chen wrote:
>> Currently, code of Loongson-2/3 is under loongson directory and code of
>> Loongson-1 is under loongson1 directory. Besides, there are Kconfig
>> options such as MACH_LOONGSON and MACH_LOONGSON1. This naming style is
>> very ugly and confusing. Since Loongson-2/3 are both 64-bit general-
>> purpose CPU while Loongson-1 is 32-bit SoC, we rename both file names
>> and Kconfig symbols from loongson/loongson1 to loongson64/loongson32.
>>
>> V2: Update Kconfig description.
> This ^^^^ needs to be below the '---' part of the patch because it
> should not be part of the commit message. It is just a changelog for the
> patch itself.
>
>>
>> Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>
>> ---
> ^^^ Please add "V2:..." here instead.
>
> --
> markos
>





[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux